Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Try to make ending tasks more reliable #6793

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Sep 20, 2024

I've seen an issue with build import not finishing ever, I am not sure how that could happen, but I am trying to make it more reliable by

  • adding the task only when token was produced
  • adding an additional field to know when task was finished and ending the task on progress in that case

@tgodzik tgodzik changed the title bugfix: Try to make ending taks more reliable bugfix: Try to make ending tasks more reliable Sep 24, 2024
I've seen an issue with build import not finishing ever, I am not sure how that could happen, but I am trying to make it more reliable by  adding an additional field to know when task was finished and ending the task on progress in that case.
@tgodzik tgodzik marked this pull request as ready for review September 26, 2024 09:43
@tgodzik tgodzik merged commit 82e4d40 into scalameta:main Oct 10, 2024
20 of 22 checks passed
@tgodzik tgodzik deleted the fix-taks branch October 10, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant